Skip to content

ENH: Add dtype_backend support to read_sql #50985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 26, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added IO SQL to_sql, read_sql, read_sql_query Arrow pyarrow functionality labels Jan 26, 2023
pandas/io/sql.py Outdated
@@ -303,6 +310,12 @@ def read_sql_table(
set to True, nullable dtypes are used for all dtypes that have a nullable
implementation, even if no nulls are present.

The nullable dtype implementation can be configured by calling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could use the ..note block now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, added

@phofl phofl added this to the 2.0 milestone Jan 30, 2023
@mroeschke mroeschke merged commit 0d9fdd4 into pandas-dev:main Jan 31, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the read_sql_arrow branch January 31, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants