TST: Remove fsspec internals from tests #50925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
Testing
|
CircleCI failure is separate and unrelated. |
phofl
approved these changes
Jan 22, 2023
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
thx @lithomas1, could you backport manually? |
iofall
pushed a commit
to iofall/pandas
that referenced
this pull request
Jan 23, 2023
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Jan 28, 2023
|
backported in #51038 |
phofl
added a commit
that referenced
this pull request
Jan 28, 2023
… tests) (#51038) TST: Remove fsspec internals from tests (#50925) Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I don't think clearing the registry does anything. The public registry var is supposed to be immutable, and we were just clearing the internal registry dict.
However, we didn't remove gcs from the known_implementations dict, so gcs would've technically still been in the registry IIUC this code correctly.
https://github.com/fsspec/filesystem_spec/blob/0f3ecd8e629043646ab19b1a2b00d895f0553a81/fsspec/registry.py#L206-L209