Skip to content

ENH: Add test for asfreq CoW when doing noop #50916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 21, 2023

xref #49473

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the construction, looks good otherwise!

@jorisvandenbossche jorisvandenbossche changed the title ENH: Add tst for asfreq CoW when doing noop ENH: Add test for asfreq CoW when doing noop Jan 23, 2023
@phofl phofl added this to the 2.0 milestone Jan 24, 2023
@jorisvandenbossche jorisvandenbossche merged commit 3886ff7 into pandas-dev:main Jan 24, 2023
@phofl phofl deleted the cow_asfreq branch January 24, 2023 13:34
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants