Skip to content

ENH: Add dtype_backend to to_numeric #50910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Enhancement Arrow pyarrow functionality labels Jan 20, 2023
@mroeschke mroeschke requested a review from phofl January 20, 2023 22:05
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like my read_json pr :)

Can we open an issue about implementing this properly?

@phofl phofl merged commit 77afbcc into pandas-dev:main Jan 22, 2023
@phofl
Copy link
Member

phofl commented Jan 22, 2023

thx @mroeschke

@phofl phofl added this to the 2.0 milestone Jan 22, 2023
@mroeschke mroeschke deleted the enh/arrow/to_numeric branch January 22, 2023 06:16
@mroeschke
Copy link
Member Author

Can we open an issue about implementing this properly?

This may be the "proper" way to implement this since the non-numeric inference & downcasting logic is all done in cython/numpy? I don't think there's any pure arrow equivalent to do this

@phofl
Copy link
Member

phofl commented Jan 23, 2023

Yeah we’d need a maybe downcast equivalent for this

iofall pushed a commit to iofall/pandas that referenced this pull request Jan 23, 2023
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants