TST: Tests for multi-index construction of an all-nan frame (GH4078) #5089
Conversation
|
@jtratner leaving for you take a look |
| else: | ||
| items = _ensure_index([n for n in names if n in ref_items]) | ||
| if len(items) != len(stacked): | ||
| raise Exception("invalid names passed _stack_arrays") |
There was a problem hiding this comment.
can u make this msg more informative ... i actually made an exception subclass in my read_html but i don't think that's necessary
There was a problem hiding this comment.
maybe ValueError? (or maybe make a InvalidDuplicate inherti from Valueerror?)
There was a problem hiding this comment.
i tried a valueerror but that broke some things, didn't get to the obttom of it ... i assume value error is caught higher up in the stack and is used in a non-error way
There was a problem hiding this comment.
it broke enough things to make figuring out why things were breaking to be a distraction from getting read_html ready
There was a problem hiding this comment.
do you have a test case that actually hits this? (it may be that was hitting with a mi in the past)
There was a problem hiding this comment.
nope can't repro it now, even if change the above to valueerror...so 👍 on the ValueError change
|
let me rebase and merge...hold a sec |
TST: Tests for multi-index construction of an all-nan frame (GH4078)
closes #4078