CLN: remove redundant latex options #50871
Conversation
|
There is one test here that checks the default for |
|
test failure seems unrelated, all other builds seem to pass. |
|
would be good if this can be reviewed for 2.0. to supplement the 2.0 to_latex changes. |
pandas/core/generic.py
Outdated
| multicolumn_format : str, default 'l' | ||
| The alignment for multicolumns, similar to `column_format` | ||
| The default will be read from the config module. | ||
| The default will be read from the config module, and is set as the option | ||
| ``styler.latex.multicol_align``. | ||
| multirow : bool, default False |
There was a problem hiding this comment.
For the arguments that changed defaults, I think the default here needs to change.
Could you also add a ..versionchange:: 2.0.0 directive in the body describing that the default changed?
There was a problem hiding this comment.
will do good spot,
There was a problem hiding this comment.
Done and test passing. Few failures in CIArm are unrelated.
Co-authored-by: Matthew Roeschke <[email protected]>
| `"longtable"`. | ||
|
|
||
| .. versionchanged:: 2.0.0 | ||
| The pandas option affecting this argument has changed. |
There was a problem hiding this comment.
For these notes could we state what the new option is i.e. ...this argument has changed to <new option>
There was a problem hiding this comment.
The main part of the parameter doc string contains the names of the pandas option that are used. Not sure we need to explicitly state it again in the versionchanged only a couple lines below?
Did add the default values though.
pandas/core/generic.py
Outdated
|
|
||
| .. versionchanged:: 2.0.0 | ||
| The pandas option affecting this argument has changed, as has the | ||
| default value. |
There was a problem hiding this comment.
Same here i.e. the default value has changed from <old> to <new>
There was a problem hiding this comment.
Have added the new default values.
|
Thanks @attack68 |
after #48970