BUG: Fix agg ingore arg/kwargs when given list like func #50863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Jan 20, 2023
|
cc @rhshadrach, I've reworked the implementation, any suggestions for improvement? |
rhshadrach
requested changes
Jan 29, 2023
rhshadrach
requested changes
Feb 3, 2023
added 2 commits
February 6, 2023 21:51
rhshadrach
requested changes
Feb 8, 2023
rhshadrach
requested changes
Feb 11, 2023
| def test__dataframe_groupy_agg_list_like_func_with_args(): | ||
| # GH 50624 | ||
| df = DataFrame({"x": [1, 2, 3], "y": ["a", "b", "c"]}) | ||
| df = df.groupby("y") |
There was a problem hiding this comment.
Can you call this gb instead; calling it df is confusing.
| def test__series_groupy_agg_list_like_func_with_args(): | ||
| # GH 50624 | ||
| data = Series([1, 2, 3]) | ||
| data = data.groupby(data) |
Comment on lines
648
to
652
| msg = r"foo1\(\) got an unexpected keyword argument 'b'" | ||
| with pytest.raises(TypeError, match=msg): | ||
| df.agg([foo1, foo2], 0, 3, b=3, c=4) | ||
|
|
||
| result = df.agg([foo1, foo2], 0, 3, c=4) |
There was a problem hiding this comment.
This test should be using resample.
doc/source/whatsnew/v2.0.0.rst
Outdated
| @@ -1317,7 +1317,7 @@ Reshaping | |||
| - Clarified error message in :func:`merge` when passing invalid ``validate`` option (:issue:`49417`) | |||
| - Bug in :meth:`DataFrame.explode` raising ``ValueError`` on multiple columns with ``NaN`` values or empty lists (:issue:`46084`) | |||
| - Bug in :meth:`DataFrame.transpose` with ``IntervalDtype`` column with ``timedelta64[ns]`` endpoints (:issue:`44917`) | |||
| - Bug in :func:`agg` would ignore arguments when passed a list of functions (:issue:`50863`) | |||
| - Bug in :meth:`DataFrame.agg`, :meth:`Series.agg`, :meth:`DataFrameGroupBy.agg`, :meth:`SeriesGroupBy.agg`, and :meth:`Resampler.agg` would ignore arguments when passed a list of functions (:issue:`50863`) | |||
There was a problem hiding this comment.
I should have mentioned - this should be split up with the groupby and resampler part going under their section within Bugfixes.
|
Thanks @luke396! |
This really couldn't have been done if it wasn't for your great help. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Previous Pull Request #50725, for multiple elements-func list this time.
I would appreciate any feedback or suggestions on this draft pull request to help improve it. Thank you in advance for your help and cooperation.