Skip to content

DOC: Fix typo in sed command in the release instructions #50854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

datapythonista
Copy link
Member

The BUILD_COMMIT in the MacPython CI is the tag name (e.g. v1.5.3) and not the version name (e.g. 1.5.3). The release instructions have it wrong, fixing it here.

Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lithomas1 lithomas1 added this to the 2.0 milestone Jan 19, 2023
@mroeschke mroeschke merged commit d58bf12 into pandas-dev:main Jan 19, 2023
@mroeschke
Copy link
Member

Thanks @datapythonista

pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants