REF: Use * syntax to make reindex kwargs keyword only #50853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
changed the title
| index = labels | ||
| axes: dict[Literal["index", "columns"], Any] = { | ||
| "index": index, | ||
| "columns": columns, |
There was a problem hiding this comment.
i think ATM "columns" is not included in Series cases. this doesn't break anything?
There was a problem hiding this comment.
Yeah columns should not be included in the Series case. Before the passed labels would be forced into the index in the Series case
|
docstrings left unchanged? |
Yea but slightly improved. Went from to more specifically what is used e.g. |
|
Going to merge, but can follow up if needed |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Jan 30, 2023
* Use newer positional only syntax * Push logic into generic, improve docs * Clarify whatsnew * Fix shared_doc * Make axis more generic * Series has different default * Add some type ignores * Fix docstring validation * doc validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enforcing #17966, this makes
DataFrame.reindexeffectively keyword only except forlabels, so removed ad-hoc logic to enforce that.Series.reindexalso has similar ad-hoc logic which can be removed.Also did some docstring cleanup for both functions.