Skip to content

CLN remove unneccessary code from array_strptime which doesn't spark joy #50830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

CLN remove unneccessary code from array_strptime which doesn't spark joy #50830

merged 1 commit into from
Jan 18, 2023

Conversation

MarcoGorelli
Copy link
Member

fmt can't be None so there's more complexity here than need be

If reviewing, I'd suggest using the "hide whitespace" option

@MarcoGorelli MarcoGorelli added Datetime Datetime data dtype Clean labels Jan 18, 2023
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Jan 18, 2023
jbrockmendel
jbrockmendel approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@mroeschke mroeschke merged commit 685cf7f into pandas-dev:main Jan 18, 2023
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @mroeschke @jbrockmendel