ENH: Add dtype to read sql to be consistent with read_sql_query #50797
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
IO SQL
mroeschke
reviewed
Jan 17, 2023
| @@ -659,6 +668,7 @@ def read_sql( | |||
| parse_dates=parse_dates, | |||
| chunksize=chunksize, | |||
| use_nullable_dtypes=use_nullable_dtypes, | |||
| dtype=dtype, | |||
There was a problem hiding this comment.
How does this interact with use_nullable_dtypes when dtype is not a nullable type?
There was a problem hiding this comment.
We should add tests for this :)
Right now we are casting to nullable and then apply astype (that's how it was implemented before as well). But I don't think that we have any tests covering this
There was a problem hiding this comment.
Yeah would be good to add tests for this case. IIRC read_csv or a similar reader had a similar thing. This should hopefully operate similarly
mroeschke
approved these changes
Jan 20, 2023
|
Thanks @phofl |
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
…as-dev#50797) * ENH: Add dtype to read sql to be consistent with read_sql_query * Add gh ref * Fix docstring * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Came across this, seemed odd to me that one supports it but not the other