REF: consolidate datetime parsing paths and exception handling #50790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke @MarcoGorelli not time-sensitive but blocker-ish for ongoing parsing simplification |
|
sure, taking a look today |
MarcoGorelli
approved these changes
Jan 20, 2023
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
…s-dev#50790) * REF: fewer paths through datetime parsing code * dont catch in conversion.pyx * REF: move exception handling within dateutil_parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last check I'd like to move down into dateutil_parse is the
if dt.tzinfo is not None:in parse_datetime_string, but it turns doing that breaks a bunch of Period parsing bc of dateutil parsing "2001-11-19/2001-11-25" as 2001-11-19 20:01:00 with a tzoffset of -1500 hours.I'm indifferent between "Unknown string format" vs "Unknown datetime string format", so happy to change to the other one.