-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Remove conda list
from sdist build causing failures
#50779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @lithomas1 I think the wheel test failures are expected (same thing is happening in your pyproject.toml PR) |
I'll take a look. |
BTW, long term, I'm thinking about replacing this workflow with the "Build sdist" workflow in the wheel builders, once we're fully ready there (just missing arm64, ideally we switch to the cibuildwheel wheel builders for the RC). There's still some nice stuff in the current sdist workflow that's missing from it, though (testing oldest supported numpy IIRC). |
IIUC, the use of the conda env is to ensure that the sdist is installable in a clean env without anything else. (When we built the sdist, we installed stuff like numpy and Cython.) |
Looks like we still have issues with numpy 1.24.x. On main, we don't have failing CI yet since some other package is pinning numpy < 1.24. |
There is a failure in main related to this: https://github.com/pandas-dev/pandas/actions/runs/3947077782 The error doesn't make sense to me, It'd be nice to have this green before the release, but this seems pretty specific to the CI configuration, not a problem with the sdist, so if there are no objections, I think I'll move forward with the release, regardless of the failure. CC: @pandas-dev/pandas-core #49857 |
It's a problem with the provision-with-micromamba Github Action. It should be fine to cut a release without this. I remember this from when I was messing around with cirun. |
conda list
from sdist build causing failures
So it appears the The environment isolation is a fair point to keep the conda environment here for now.
With this in mind, I suppose if this temporarily fixes the failures in the sdist build we can just remove this |
Going to push this in as it allows the sdist jobs to pass on main and all this does is remove a |
…#50779) * CI: Remove conda fromm sdist build * Just don 't conda list
I think the purpose of this build is to see if the sdist is pip install-able in which case I'm not sure why we are setting up conda just to do a
conda list
.