Skip to content

CI: Remove conda list from sdist build causing failures #50779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

mroeschke
Copy link
Member

I think the purpose of this build is to see if the sdist is pip install-able in which case I'm not sure why we are setting up conda just to do a conda list.

@mroeschke mroeschke added Build Library building on various platforms CI Continuous Integration labels Jan 16, 2023
@mroeschke
Copy link
Member Author

cc @lithomas1 I think the wheel test failures are expected (same thing is happening in your pyproject.toml PR)

@mroeschke mroeschke added this to the 2.0 milestone Jan 17, 2023
@lithomas1
Copy link
Member

cc @lithomas1 I think the wheel test failures are expected (same thing is happening in your pyproject.toml PR)

I'll take a look.

@lithomas1
Copy link
Member

BTW, long term, I'm thinking about replacing this workflow with the "Build sdist" workflow in the wheel builders, once we're fully ready there (just missing arm64, ideally we switch to the cibuildwheel wheel builders for the RC).

There's still some nice stuff in the current sdist workflow that's missing from it, though (testing oldest supported numpy IIRC).

@lithomas1
Copy link
Member

I think the purpose of this build is to see if the sdist is pip install-able in which case I'm not sure why we are setting up conda just to do a conda list.

IIUC, the use of the conda env is to ensure that the sdist is installable in a clean env without anything else.

(When we built the sdist, we installed stuff like numpy and Cython.)

@lithomas1
Copy link
Member

Looks like we still have issues with numpy 1.24.x.

On main, we don't have failing CI yet since some other package is pinning numpy < 1.24.

@datapythonista
Copy link
Member

There is a failure in main related to this: https://github.com/pandas-dev/pandas/actions/runs/3947077782

The error doesn't make sense to me, always_yes is only defined once. If we decide to remove conda as proposed in this PR, that would fix the error. Or maybe the problem comes from installing conda after installing python using the github action. Maybe better to setup conda directly, and just create a new environment at the end to install the sdist on it.

It'd be nice to have this green before the release, but this seems pretty specific to the CI configuration, not a problem with the sdist, so if there are no objections, I think I'll move forward with the release, regardless of the failure.

CC: @pandas-dev/pandas-core #49857

@datapythonista datapythonista mentioned this pull request Jan 18, 2023
2 tasks
@lithomas1
Copy link
Member

It's a problem with the provision-with-micromamba Github Action. It should be fine to cut a release without this.

I remember this from when I was messing around with cirun.

@mroeschke mroeschke changed the title CI: Remove conda from sdist build CI: Remove conda list from sdist build causing failures Jan 18, 2023
@mroeschke
Copy link
Member Author

So it appears the conda list specifically was causing the "always_yes" failure here.

The environment isolation is a fair point to keep the conda environment here for now.

BTW, long term, I'm thinking about replacing this workflow with the "Build sdist" workflow in the wheel builders, once we're fully ready there (just missing arm64, ideally we switch to the cibuildwheel wheel builders for the RC).

With this in mind, I suppose if this temporarily fixes the failures in the sdist build we can just remove this conda list for now

@mroeschke
Copy link
Member Author

Going to push this in as it allows the sdist jobs to pass on main and all this does is remove a conda list output, especially since this may be replace with a step in the wheel builder workflow

@mroeschke mroeschke merged commit 626b651 into pandas-dev:main Jan 23, 2023
@mroeschke mroeschke deleted the bld/sdist/remove_conda branch January 23, 2023 19:46
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
…#50779)

* CI: Remove conda fromm sdist build

* Just don
't conda list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants