Skip to content

BUG: Make Index, Int64Index and MI repr evalable #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2013

Conversation

jtratner
Copy link
Contributor

@jtratner jtratner commented Oct 2, 2013

MI repr was missing a comma between its arguments and Index reprs needed
to quote their dtypes.

Only talking about Index, Int64Index and
MultiIndex. Tseries indices (like PeriodIndex and DatetimeIndex) are
more complicated and could be covered separately.

@jtratner
Copy link
Contributor Author

jtratner commented Oct 2, 2013

To be clear, the major change is to add commas between MI attributes and quote dtypes for Index. So, pre this PR:

repr(Index(range(10)))
Int64Index([1, 2, 3, 4, 5, 6, 7, 8, 9, 10], dtype=int64)

With this PR

repr(Index(range(10)))
Int64Index([1, 2, 3, 4, 5, 6, 7, 8, 9, 10], dtype='int64')

Everybody okay with that?

@jreback
Copy link
Contributor

jreback commented Oct 11, 2013

ok with this

@jtratner
Copy link
Contributor Author

Okay, I'll make sure it still passes and then push.

Only talking about Index, Int64Index and MultiIndex. Tseries indices
(like PeriodIndex and DatetimeIndex) are more complicated and could be
covered separately.
jtratner added a commit that referenced this pull request Oct 12, 2013
BUG: Make Index, Int64Index and MI repr evalable
@jtratner jtratner merged commit 282bf26 into pandas-dev:master Oct 12, 2013
@jtratner jtratner deleted the fix-mi-repr branch October 12, 2013 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants