Skip to content

TYP: fix NDFrame._value type #50763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

TYP: fix NDFrame._value type #50763

merged 1 commit into from
Jan 18, 2023

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented Jan 15, 2023

xref #37715

Fixes the type of NDFrame._value and allow to remove 2 related # type: ignore

Thanks!

jbrockmendel
jbrockmendel approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @simonjayhawkins

@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Jan 17, 2023
@mroeschke mroeschke added this to the 2.0 milestone Jan 18, 2023
@mroeschke mroeschke merged commit 68cc56d into pandas-dev:main Jan 18, 2023
@mroeschke
Copy link
Member

Thanks @EdAbati

@EdAbati EdAbati deleted the fix-type-ndframe-values branch January 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EdAbati @mroeschke @jbrockmendel