-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: list supported float dtypes I #50738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,7 @@ def to_numeric( | |
|
||
- 'integer' or 'signed': smallest signed int dtype (min.: np.int8) | ||
- 'unsigned': smallest unsigned int dtype (min.: np.uint8) | ||
- 'float': smallest float dtype (min.: np.float32) | ||
- 'float': float dtype (min.: np.float32), float16 is not supported. | ||
MarcoGorelli marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TBH I think this one's clear enough as it is - if it says There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a good point. After re-consideration, I agree. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's revert this change |
||
|
||
As this behaviour is separate from the core conversion to | ||
numeric values, any errors raised during the downcasting | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this has gone forward by one space 😄 any chance you could bring it back to where it was, to minimise the diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @MarcoGorelli . I was wondering why my diff was so unreadable. I deleted one space, now it looks nicer 😄.
Also, I reverted line 73 as you suggested.