-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST/CI: make sure that locales are tested #5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we pass on these? so #4918 can close? (or maybe have him retest, AFAIK all the other issues are resolved) |
was not writing to the init file bc duh i should write directly to pandas repo, not after it's installed i'm actually doing what @Komnomnomnom did to repro the issue by setting the locale in Python at the top of |
@jreback getting those errors py26: https://travis-ci.org/cpcloud/pandas/jobs/12032903 also some new errors show up in the slow build https://travis-ci.org/cpcloud/pandas/jobs/12032904 guess the locale wasn't really being set before |
gr8! |
do you know why the google tests are failing? |
no...will also require some digging |
@avalentino can you test again when you get a chance? thanks. |
Just one error remaining
|
cc @Komnomnomnom can you give a quick look, this is in a non-us locale: |
I think this is a problem with the test, I consistently get:
The test requests data from {"errors": [{"message": "The Twitter REST API v1 is no longer active. Please migrate to API v1.1. https://dev.twitter.com/docs/api/1.1/overview.", "code": 68}]} and according to the twitter docs
So 1 I'm not sure @avalentino why you aren't seeing the SKIP, it does look like JSON is being passed an empty string in your case: In [2]: pd.read_json('')
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
<ipython-input-2-2bbdc38cf707> in <module>()
----> 1 pd.read_json('')
ValueError: Expected object or value 2 @jreback, @cpcloud what do you want to do with this test (I'm not the original author). Remove it or find a different url? |
FYI the test passes for me (in it_IT locale) if I remove the twitter request (it's already sending a request to github anyway and it doesn't even check the twitter result so it's pretty redundant regardless). |
couldn't we use this? |
yep that looks good ... i'll update the test |
actually nvm we can just remove the twitter ... it's already being tested with github's API |
looks ok to me |
@avalentino Can u give this another go and see if anything turns up? Thanks |
nothing crazy here just cleaning up a bit of rot in the CI stuff and |
TST/CI: make sure that locales are tested
related #4918