Skip to content

DOC: Add note in 1.5.3 about SQLAlchemy warnings #50680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2023
Merged

DOC: Add note in 1.5.3 about SQLAlchemy warnings #50680

merged 3 commits into from
Jan 12, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 11, 2023 •
edited
Loading

xref #50558

As discussed in todays dev call, for 1.5.3 the decision was to document that SQLAlchemy warnings can be expected but not addressed.

@mroeschke mroeschke added Docs IO SQL to_sql, read_sql, read_sql_query labels Jan 11, 2023
@mroeschke mroeschke added this to the 1.5.3 milestone Jan 11, 2023
phofl
phofl reviewed Jan 12, 2023
View reviewed changes
doc/source/whatsnew/v1.5.3.rst Outdated

.. note::

If you are using :meth:`DataFrame.to_sql`, :func:`read_sql`, :func:`read_sql_table`, or :func:`read_sql_query` with SQLAlchemy 1.4.6 or greater,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.46

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixed

phofl
phofl reviewed Jan 12, 2023
View reviewed changes
doc/source/whatsnew/v1.5.3.rst Outdated
.. note::

If you are using :meth:`DataFrame.to_sql`, :func:`read_sql`, :func:`read_sql_table`, or :func:`read_sql_query` with SQLAlchemy 1.4.6 or greater,
you may see a ``sqlalchemy.exc.RemovedIn20Warning``. These warnings can be safely ignored as pandas works toward compatibility with SQLAlchemy 2.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reword the last part? These warnings can be safely ignored for the SQLAlchemy 1.4.x releases as pandas works towards compatibility ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Changed

@phofl phofl merged commit eddb6f4 into pandas-dev:main Jan 12, 2023
@phofl
Copy link
Member

phofl commented Jan 12, 2023

thx @mroeschke

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 12, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 eddb6f459a6b32112f614a9118659ef763b50db1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50680: DOC: Add note in 1.5.3 about SQLAlchemy warnings'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50680-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50680 on branch 1.5.x (DOC: Add note in 1.5.3 about SQLAlchemy warnings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl
Copy link
Member

phofl commented Jan 12, 2023

@meeseeksdev backport to 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 12, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 eddb6f459a6b32112f614a9118659ef763b50db1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50680: DOC: Add note in 1.5.3 about SQLAlchemy warnings'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50680-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50680 on branch 1.5.x (DOC: Add note in 1.5.3 about SQLAlchemy warnings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl pushed a commit to phofl/pandas that referenced this pull request Jan 12, 2023
@mroeschke @phofl
DOC: Add note in 1.5.3 about SQLAlchemy warnings (pandas-dev#50680)
2c92cf4
@phofl phofl mentioned this pull request Jan 12, 2023
Merged
phofl added a commit that referenced this pull request Jan 12, 2023
@phofl @mroeschke
Backport PR on Branch 1.5.x (DOC: Add note in 1.5.3 about SQLAlchemy …
0cc9eca 
…warnings) (#50693)

DOC: Add note in 1.5.3 about SQLAlchemy warnings (#50680)

Co-authored-by: Matthew Roeschke <[email protected]>
@mroeschke mroeschke deleted the doc/sqlalchemy_whatsnew branch January 12, 2023 15:58
@mroeschke mroeschke mentioned this pull request Jan 13, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Docs IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl