Skip to content

DEPR: Add FutureWarning for pandas.io.sql.execute #50638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

DEPR: Add FutureWarning for pandas.io.sql.execute #50638

wants to merge 14 commits into from

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Jan 9, 2023

@luke396 luke396 changed the title DEPR: Add-FutureWarning-pandas.io.sql.execute DEPR: Add FutureWarning for pandas.io.sql.execute Jan 9, 2023
phofl
phofl reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc build is failing, mightt be related.

Could you remove all mentions in the docs?

@luke396
Copy link
Contributor Author

luke396 commented Jan 9, 2023

Doc build is failing, mightt be related.

Could you remove all mentions in the docs?

Your mean is remove ':func:pandas.io.sql.execute` 'in .rst ?

@phofl
Copy link
Member

phofl commented Jan 9, 2023

Ah no, I think we mention this function in the user guide, this reference should be removed

@luke396
Copy link
Contributor Author

luke396 commented Jan 10, 2023 •
edited
Loading

Ah no, I think we mention this function in the user guide, this reference should be removed

Fine, I will do it.

The function seems not be mentioned in the user guide or any .rst file. I find some examples in comments use the function, and I change them.

Hope this will work!

@luke396
Copy link
Contributor Author

luke396 commented Jan 10, 2023

image

May be this need some attention, in check Doc Build and Upload / Doc Build and Upload

@luke396 luke396 requested a review from phofl January 11, 2023 13:45
phofl
phofl reviewed Jan 11, 2023
View reviewed changes
pandas/core/generic.py Outdated
@@ -2858,8 +2858,11 @@ def to_sql(

>>> df.to_sql('users', con=engine)
3
>>> engine.execute("SELECT * FROM users").fetchall()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this, this is an alchemy engine, not our execute

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all the examples below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all the examples below

I seem to mess up the whole PR, I will reopen a new on 😢

@luke396 luke396 closed this Jan 11, 2023
@luke396 luke396 mentioned this pull request Jan 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPR: pandas.io.sql.execute
2 participants
@luke396 @phofl