Skip to content

BUG: groupby with empty object, categorical grouper, and dropna=False fails #50635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

BUG: groupby with empty object, categorical grouper, and dropna=False fails #50635

merged 1 commit into from
Jan 9, 2023

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach added Bug Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Categorical Categorical Data Type labels Jan 9, 2023
@rhshadrach rhshadrach added this to the 2.0 milestone Jan 9, 2023
@gfyoung
Copy link
Member

gfyoung commented Jan 9, 2023 •
edited
Loading

LGTM pending CI ✅

@mroeschke mroeschke merged commit f12e2a7 into pandas-dev:main Jan 9, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the test_dropna_false_default branch January 10, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Categorical Categorical Data Type Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: groupby with empty object, categorical grouper, and dropna=False fails
3 participants
@rhshadrach @gfyoung @mroeschke