REF: avoid catching and re-raising in datetime parsing #50629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Refactor
MarcoGorelli
approved these changes
Jan 9, 2023
| dt = parse_datetime_string( | ||
| ts, dayfirst=dayfirst, yearfirst=yearfirst | ||
| ) | ||
| except (ValueError, OverflowError) as err: | ||
| raise ValueError("could not convert string to Timestamp") from err | ||
| except ValueError as err: |
There was a problem hiding this comment.
looks like there was no test which hit the OverflowError anyway, nice
Comment on lines
-549
to
-551
| except ValueError: | ||
| # Fall through to parse_datetime_string | ||
| pass |
There was a problem hiding this comment.
looks like this was uncovered, so OK to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from a branch re-using _convert_str_to_tsobject in array_to_datetime cc @MarcoGorelli