Skip to content

PERF: groupby.any/all with object dtype #50623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2023
Merged

PERF: groupby.any/all with object dtype #50623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
577646b
PERF: groupby.any/all with object dtype
lukemanley Jan 7, 2023
57acb3e
add comment, skip copy if possible
lukemanley Jan 7, 2023
6eb636d
gh ref
lukemanley Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v2.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,7 @@ Removal of prior version deprecations/changes
Performance improvements
~~~~~~~~~~~~~~~~~~~~~~~~
- Performance improvement in :meth:`.DataFrameGroupBy.median` and :meth:`.SeriesGroupBy.median` and :meth:`.GroupBy.cumprod` for nullable dtypes (:issue:`37493`)
- Performance improvement in :meth:`.DataFrameGroupBy.all`, :meth:`.DataFrameGroupBy.any`, :meth:`.SeriesGroupBy.all`, and :meth:`.SeriesGroupBy.any` for object dtype (:issue:`#####`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use PR # here assuming there is no issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thx

- Performance improvement in :meth:`MultiIndex.argsort` and :meth:`MultiIndex.sort_values` (:issue:`48406`)
- Performance improvement in :meth:`MultiIndex.size` (:issue:`48723`)
- Performance improvement in :meth:`MultiIndex.union` without missing values and without duplicates (:issue:`48505`, :issue:`48752`)
Expand Down
19 changes: 5 additions & 14 deletions pandas/core/groupby/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,22 +1774,13 @@ def _bool_agg(self, val_test: Literal["any", "all"], skipna: bool):
"""

def objs_to_bool(vals: ArrayLike) -> tuple[np.ndarray, type]:
if is_object_dtype(vals.dtype):
if is_object_dtype(vals.dtype) and skipna:
# GH#37501: don't raise on pd.NA when skipna=True
if skipna:
func = np.vectorize(
lambda x: bool(x) if not isna(x) else True, otypes=[bool]
)
vals = func(vals)
else:
vals = vals.astype(bool, copy=False)

vals = cast(np.ndarray, vals)
vals = vals.copy()
vals[isna(vals)] = True
Copy link
Member

@phofl phofl Jan 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that we will re-compute a mask later on? Hard to follow why setting = True is valid if you don't know that.

Additionally, would it be faster to check if isna(vale).any() before making a copy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment and skipped the copy when possible. Seems to save a bit more more (~5%).

elif isinstance(vals, BaseMaskedArray):
vals = vals._data.astype(bool, copy=False)
else:
vals = vals.astype(bool, copy=False)

vals = vals._data
vals = vals.astype(bool, copy=False)
return vals.view(np.int8), bool

def result_to_bool(
Expand Down