Skip to content

ENH: guess ISO8601 formats without separators #50622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

ENH: guess ISO8601 formats without separators #50622

merged 1 commit into from
Jan 9, 2023

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli added the Datetime Datetime data dtype label Jan 7, 2023
@MarcoGorelli MarcoGorelli requested a review from WillAyd January 7, 2023 16:09
@gfyoung
Copy link
Member

gfyoung commented Jan 8, 2023

Is there anything user-facing that gets a boost (whatsnew) from this? Otherwise, LGTM.

@MarcoGorelli
Copy link
Member Author

thanks - not yet, this'll make a user-facing since PDEP4 (in which to_datetime always attempts to guess the format and to parse consistently)

WillAyd
WillAyd approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mroeschke mroeschke added this to the 2.0 milestone Jan 9, 2023
@mroeschke mroeschke merged commit 89a018e into pandas-dev:main Jan 9, 2023
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

ENH: guess ISO8601 formats without separators
4 participants
@MarcoGorelli @gfyoung @mroeschke @WillAyd