ENH: CoW Replace #50618
Closed
ENH: CoW Replace #50618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
force-pushed
the
enh-cow-replace
branch
from
d6ca69e to
f638abd
Compare
|
@phofl I think I got this to work now, let me know if this approach is correct. |
lithomas1
commented
Jan 14, 2023
| blk.set_inplace(blk_locs, value_getitem(val_locs), copy=True) | ||
| self._clear_reference_block(blkno_l) | ||
| leftover_blocks = tuple(blk.delete(blk_locs)) | ||
| vals = np.broadcast_to( |
There was a problem hiding this comment.
If new_block_2d doesn't copy vals, will need to make a copy since output of np.broadcast_to isn't writable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Sits on top of #50148. (will rebase afterwards).