Skip to content

DEPR: Enforce disallowing 2 positional args in DataFrame.reindex #50612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2023
Merged

DEPR: Enforce disallowing 2 positional args in DataFrame.reindex #50612

merged 2 commits into from
Jan 7, 2023

Conversation

mroeschke
Copy link
Member

Introduced in #17966

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Jan 7, 2023
phofl
phofl reviewed Jan 7, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a dockets failure:

FAILED pandas/util/_validators.py::pandas.util._validators.validate_axis_style_args

otherwise lgtm

@phofl phofl added this to the 2.0 milestone Jan 7, 2023
@phofl phofl merged commit 18865cf into pandas-dev:main Jan 7, 2023
@phofl
Copy link
Member

phofl commented Jan 7, 2023

thx @mroeschke

@mroeschke mroeschke deleted the depr/rm/reindex_positional branch January 9, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl