-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
VIS: let scatter plots obey mpl color scheme (#3338) #5060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cpcloud ? |
pulling it down now |
@cpcloud How did you obtain this plot? If I do (example from the docs): pd.options.display.mpl_style = 'default'
df = pd.DataFrame(np.random.randn(1000, 4), index=pd.date_range('1/1/2000', periods=1000), columns=list('ABCD'))
df = df.cumsum()
df.plot() I get the new color scheme, as you also see in the docs: http://pandas.pydata.org/pandas-docs/dev/visualization.html#basic-plotting-plot |
@cpcloud Ah, it seems like you posted the plot in this part of the docs: http://pandas.pydata.org/pandas-docs/dev/visualization.html#suppressing-tick-resolution-adjustment Well, this one is generated by explicitly stating the colors you want ( Off course, we could remove this
to get rid of these colors in the docs, but then the purpose of the example is a little bit lost, because you could do the same with just |
@jorisvandenbossche ready to go? |
@cpcloud this ok? |
@jreback for me this is ready |
Yep good 2 go |
VIS: let scatter plots obey mpl color scheme (#3338)
Closes #3338.
Fixes the remaining plot functions that don't follow the matplotlib style (functions based on scatter plots).
Rationale:
c
to default one defined in matplotlibs rcParams ifc
was not specified by the user (becausec='b'
is harcoded in matplotlibscatter
method).color
keyword is not checked because, if specified by the user, it already is given preference by matplotlib overc
if both are given.There is a new PR on scatter based plotting methods (#3473), but I suppose that it can be handled in that PR to ensure this new plotting method also follows this approach?