TST: Copy on Write for filter #50589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 tasks
whoiskatrin
reviewed
Jan 5, 2023
| df_orig = df.copy() | ||
| df2 = df.filter(**filter_kwargs) | ||
| if using_copy_on_write: | ||
| assert np.shares_memory(get_array(df2, "a"), get_array(df, "a")) |
There was a problem hiding this comment.
Out of curiosity, do you think that numpy.may_share_memory() function can be faster than using np.shares_memory()? I compared it once, and it seems like it could be the case, but not super important.
There was a problem hiding this comment.
This doesn't really matter for tests, but seems like it could be faster
lithomas1
commented
Jan 5, 2023
|
|
||
| # mutating df2 triggers a copy-on-write for that column/block | ||
| if using_copy_on_write: | ||
| df2.iloc[0, 0] = 0 |
There was a problem hiding this comment.
This was raising a SettingWithCopy error(reasonable, since filter uses loc) so I just moved it inside the CoW case.
There was a problem hiding this comment.
Yeah had the same problem somewhere else
phofl
approved these changes
Jan 6, 2023
|
thx @lithomas1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.