CI: Try with sqlalchemy warnings #50580
Conversation
|
Thanks. Would the goal be to fully address #50558? |
|
Not sure if the con.begin() will fix everything. If yes, then this should cover the issue. |
|
cc @mroeschke I am optimistic that this will do it (hopefully :)) Do we want to keep the warnings active on main as well till we can test against alchemy 2.0 or should I remove the env variable again? |
|
I'm okay keeping the sqlalchemy warnings active on main (should hopefully aspire for sqlalchemy 2.0 compatibility so keeping these active will hopefully help) |
|
CircleCI is green, this is a good sign :) |
| @@ -879,11 +893,11 @@ def load_test_data_and_sql(self): | |||
| create_and_load_iris_view(self.conn) | |||
|
|
|||
| def test_read_sql_view(self): | |||
| iris_frame = sql.read_sql_query("SELECT * FROM iris_view", self.conn) | |||
| iris_frame = sql.read_sql_query(self.text("SELECT * FROM iris_view"), self.conn) | |||
There was a problem hiding this comment.
Is this something that we actually need to fix in read_sql_query itself?
str is one of the accepted values for the sql parameter.
There was a problem hiding this comment.
Can you open an issue about this? I would prefer pushing this to the user, because otherwise we would have to deal with SQLite without alchemy vs cases with alchemy
pandas/tests/io/test_sql.py
Outdated
| @pytest.mark.skip(reason="sorted on strings and integers") | ||
| def test_read_sql_parameter(self): | ||
| self._read_sql_iris_parameter() |
There was a problem hiding this comment.
There is some weird sort going on on the parameters to that query. They contain integers and strings which causes an error
|
The lite tests yes, I don’t have MySQL or Postgres set up locally… |
# Conflicts: # ci/deps/actions-310.yaml # ci/deps/actions-38-downstream_compat.yaml # ci/deps/actions-38.yaml # ci/deps/actions-39.yaml # ci/deps/circle-38-arm64.yaml # environment.yml # requirements-dev.txt
jbrockmendel
added
IO SQL
|
i think ive got postgres running on my server. would it help if i test this branch there? |
|
I am leaning towards not fixing the auto commit problems now, since @cdcadman mentioned that he has a branch tackling these. The text problems are all fixed. But generally speaking, help is welcome here :) |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.