Skip to content

DEPR: Remove silent dropping of nuisance columns in window ops #50576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 6, 2023
Merged

DEPR: Remove silent dropping of nuisance columns in window ops #50576

merged 8 commits into from
Jan 6, 2023

Conversation

mroeschke
Copy link
Member

Introduced in #42834

@mroeschke mroeschke added Deprecate Functionality to remove in pandas Window rolling, ewma, expanding labels Jan 4, 2023
datapythonista
datapythonista approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mroeschke

@datapythonista datapythonista mentioned this pull request Jan 5, 2023
Open
@mroeschke mroeschke mentioned this pull request Jan 5, 2023
Closed
@mroeschke mroeschke added this to the 2.0 milestone Jan 5, 2023
@mroeschke
Copy link
Member Author

Failures are unrelated (sqlalchemy 2.0 warnings)

@mroeschke mroeschke merged commit 5483590 into pandas-dev:main Jan 6, 2023
@mroeschke mroeschke deleted the depr/rm/window_nuisance branch January 6, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Window rolling, ewma, expanding
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @datapythonista