Skip to content

TYP: Better numeric test types #50571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2023
Merged

TYP: Better numeric test types #50571

merged 3 commits into from
Jan 9, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Jan 4, 2023 •
edited
Loading

Currently we have that:

  • UNSIGNED_INT_NUMPY_DTYPES
  • SIGNED_INT_NUMPY_DTYPES
  • ALL_INT_NUMPY_DTYPES

have dtype list[Dtype]. This is a too broad dtype, and the better dtype for these objects is list[NpDtype].

Extracted from newest version of #49560.

@topper-123 topper-123 changed the title Better numeric test types TYP: Better numeric test types Jan 4, 2023
@topper-123 topper-123 mentioned this pull request Jan 5, 2023
Merged
@topper-123 topper-123 force-pushed the _better_numeric_test_types branch from 280c257 to 586b947 Compare January 7, 2023 17:45
@topper-123 topper-123 marked this pull request as ready for review January 8, 2023 01:08
@gfyoung gfyoung added Typing type annotations, mypy/pyright type checking Testing pandas testing functions or related to the test suite labels Jan 8, 2023
@mroeschke mroeschke added this to the 2.0 milestone Jan 9, 2023
@mroeschke mroeschke merged commit 6f719b2 into pandas-dev:main Jan 9, 2023
@mroeschke
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the _better_numeric_test_types branch January 10, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @mroeschke @gfyoung