ENH: Add lazy copy to pipe #50567
Merged
ENH: Add lazy copy to pipe #50567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 tasks
pandas/core/generic.py
Outdated
Comment on lines
5774
to
5776
| result = common.pipe(self, func, *args, **kwargs) | ||
| if _using_copy_on_write(): | ||
| return result.copy(deep=None) |
There was a problem hiding this comment.
Should we pass in self.copy(deep=None) to the pipe, instead of shallow copying the result?
Or do we have guarantees at the moment about that a piped function can mutate the dataframe inplace?
There was a problem hiding this comment.
Good point, this should be the other way round, will adjust accordingly and add tests
There was a problem hiding this comment.
Moved and added another test modifying the object inplace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.