Updating and re-opening PR #48275 #50542
Conversation
|
Mistyped the issue number in that commit message, should be #47953. |
| tm.assert_series_equal(resultarray1, expectedarray) | ||
| tm.assert_series_equal(resultarray2, expectedarray) | ||
|
|
||
| df = DataFrame({"T": [Timestamp("2019-04-30")], "D": [DateOffset(months=1)]}) |
gfyoung
added
Bug
Timestamp
There was a problem hiding this comment.
thanks @srotondo for working on this!
The change looks fine to me, if you address the comments on tests I think we can get this in
| startscalar = Timestamp("2020-01-30") | ||
| startarray = Series([Timestamp("2020-01-30")]) |
There was a problem hiding this comment.
could these be parametrised over?
| } | ||
| ) | ||
| frameresult2 = df2["T"] + 26 * df2["D"] | ||
| assert frameresult1[0] == frameresult2[0] |
There was a problem hiding this comment.
any chance they could both be checked against some expected output? otherwise perhaps in the future they could both change and become wrong?
There was a problem hiding this comment.
Sure, I can do that. I haven't had much time to work on this recently, but I'll try to handle all these comments when I find some time to deal with them.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Sorry this went stale, I've been really busy lately, I think I'll be able to find time to clean this up soon. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.