CLN explicit casts to float to avoid implicit casts #50540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 3, 2023
| @@ -54,6 +54,8 @@ def seed_df(seed_nans, n, m): | |||
| "3rd": np.random.randint(1, m + 1, n), | |||
| } | |||
| ) | |||
| # Explicitly cast to float to avoid implicit cast when setting nan | |||
| frame["3rd"] = frame["3rd"].astype("float") | |||
There was a problem hiding this comment.
Shouldn't this be needed only if this hits if seed_nans?
There was a problem hiding this comment.
you're right, thanks!
mroeschke
approved these changes
Jan 4, 2023
|
Thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #50493
There are places when an implicit cast happens, but it's not the purpose of the test - the cast might as well be done explicitly then
This would help pave the way towards PDEP6