-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Added a new format in parsing.pyx #50523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are failing, can you fix this up please?
I looked but couldn't figure out what was wrong, could you help |
I'd suggest you start by stepping through this part of the code (in particular the tokens) to understand what it does - once you've really understood it, you should be ready to submit a fix |
Yeah I'll do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests still failing
if you haven't understood what the code does, that's fine, there's other issues you're welcome to work on
closing for now then, there's no point in guessing fixes - thanks anyway for your PR! |
ok |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.