Skip to content

ENH: Added a new format in parsing.pyx #50523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

ENH: Added a new format in parsing.pyx #50523

wants to merge 5 commits into from

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Jan 1, 2023

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing, can you fix this up please?

@ramvikrams
Copy link
Contributor Author

tests are failing, can you fix this up please?

I looked but couldn't figure out what was wrong, could you help

@MarcoGorelli
Copy link
Member

tests are failing, can you fix this up please?

I looked but couldn't figure out what was wrong, could you help

I'd suggest you start by stepping through this part of the code (in particular the tokens) to understand what it does - once you've really understood it, you should be ready to submit a fix

@ramvikrams
Copy link
Contributor Author

tests are failing, can you fix this up please?

I looked but couldn't figure out what was wrong, could you help

I'd suggest you start by stepping through this part of the code (in particular the tokens) to understand what it does - once you've really understood it, you should be ready to submit a fix

Yeah I'll do that

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests still failing

if you haven't understood what the code does, that's fine, there's other issues you're welcome to work on

@MarcoGorelli
Copy link
Member

closing for now then, there's no point in guessing fixes - thanks anyway for your PR!

@ramvikrams
Copy link
Contributor Author

closing for now then, there's no point in guessing fixes - thanks anyway for your PR!

ok

@ramvikrams ramvikrams deleted the t12 branch January 3, 2023 15:37
@ramvikrams ramvikrams restored the t12 branch January 3, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: guess ISO8601 formats without separators
2 participants