CLN: Fixups to exceptions in generic #5051
Conversation
|
@jtratner this still relevant? close? |
|
I'll either close or fix this tonight.
|
|
this looks fine....merge at your leisure |
|
|
||
| # does this test make sense? | ||
| # with tm.assertRaisesRegexp(ValueError, 'duplicate axes'): | ||
| # self.panel.transpose('minor', 'major', major='minor', minor='items') |
There was a problem hiding this comment.
so what about this test and the previous? Can we just get rid of them?...they're pretty strange (and don't actually work in master for their original purpose)
There was a problem hiding this comment.
what do you mean, it is testing if their are enough arguments and is raising an error appropriately
There was a problem hiding this comment.
@jreback what i mean is that the first should really be 'duplicate axes' and not 'not enough arguments' given that positional argument is supposed to reflect the minor axis but those were the assertion errors they previously generated. I don't really care either way, what do you want to do?
|
@jtratner closing this? |
|
I'll push it to 0.14 - I think there's one item from this I want to include. |
|
np. |
Improved message and better exception types.
Improved message and better exception types.