Skip to content

BUG: loc.setitem coercing rhs df dtypes #50475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2023
Merged

BUG: loc.setitem coercing rhs df dtypes #50475

merged 3 commits into from
Jan 6, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 28, 2022

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Dtype Conversions Unexpected or buggy dtype conversions labels Dec 28, 2022
@phofl phofl added this to the 2.0 milestone Jan 6, 2023
jbrockmendel
jbrockmendel approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockmendel
Copy link
Member

CI fail is unrelated

@jbrockmendel jbrockmendel merged commit 53c1425 into pandas-dev:main Jan 6, 2023
@jbrockmendel
Copy link
Member

thanks @phofl

@phofl phofl deleted the 50467 branch January 7, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: unwanted type conversion when partial reassigning
2 participants
@phofl @jbrockmendel