ERR: "day out of range" doesn't show position of error #50464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
show-position-always
branch
from
af31616 to
83274a0
Compare
12 tasks
MarcoGorelli
force-pushed
the
show-position-always
branch
from
83274a0 to
b283338
Compare
MarcoGorelli
commented
Dec 28, 2022
| raise ValueError(f"time data \"{val}\" at position {i} doesn't " | ||
| raise ValueError(f"time data \"{val}\" doesn't " |
There was a problem hiding this comment.
Rather than trying to set as position {i} in each place where an error can occur, it's more reliable to just preprend at position {i} when an error is caught (see below)
There was a problem hiding this comment.
I haven't done the same in tslib.pyx because when format is provided, that code is going to be called here anyway in #50242
So for now I've just made sure the error messages match for the two paths
MarcoGorelli
force-pushed
the
show-position-always
branch
from
b283338 to
368e38a
Compare
MarcoGorelli
commented
Dec 28, 2022
Comment on lines
+2579
to
+2589
| ( | ||
| "2015-04-31", | ||
| "%Y-%m-%d", | ||
| '^time data "2015-04-31" doesn\'t match format "%Y-%m-%d", ' | ||
| "at position 0$", | ||
| ), | ||
| ( | ||
| "2015-31-04", | ||
| "%Y-%d-%m", | ||
| "^day is out of range for month, at position 0$", | ||
| ), |
There was a problem hiding this comment.
note how the ISO and non-ISO messages don't quite match yet - this PR just ensures that they both show the position of the error
#50242 will ensure that the messages match
mroeschke
approved these changes
Dec 28, 2022
mroeschke
added
Datetime
|
Thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Haven't added a whatsnew note, as this can be considered a follow-up to #50366