-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI/WEB: Use Github token to authenticate API calls #50388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this work locally? My impression was, that multiple doc builds were running on the same machine which caused us to hit the limit.
Haven't looked into this closely, but maybe the problem is that we have too many maintainers 🤣 , causing us to hit the API rate limit(I think it's set really low by default by Github). We should probably figure out a way to use the GITHUB_TOKEN to call the API on CI, and fall back to unauthenticated API use when its not present(e.g. developing locally). |
Changed to use the |
Thx, lets give it a shot |
Hopefully to help the doc and web build sometimes failing because of hitting the rate limit of the GIthub API