Update link to Categorical._codes removal in 2.0 what's new doc
#50351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we point to the deprecation prs in general. |
|
Ah, happy to close this PR if it's against an agreed upon standard practice. FWIW I will say I found it confusing as the PR wasn't consistent text in the changelog entry. |
|
Yeah we typically link to the PR that introduces the deprecation (which hopefully links to the PR that enforces the deprecation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is pointing to the PR where
Categorical._codeswas deprecated inpandas=1.3(#41429) instead of the PR where it was removed forpandas=2.0(#49258)