-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Use regular solver for docker build #50341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Newest numpy and numba are incompatible, so the docker build fails without taking dependencies into account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @phofl
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
the dockerfile in 1.5.x is very different, does this need backporting? |
Wasn't aware of that, are we using mamba there? If yes, then we don't have to backport |
yup |
we've backported the docker changes, so let's backport this too @meeseeksdev please backport to 1.5.x |
… build) (#50422) Backport PR #50341: CI: Use regular solver for docker build Co-authored-by: Patrick Hoefler <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.