-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BLD: Add pyproject.toml to wheels #50330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! Should we add a custom |
Well, the wheel builder failures show that this definetely fixes it. I've also done a slight modification to make --strict-data-files opt out instead of opt in. This also have the benefit of not showing a confusing no such option error, when you mistype in the path to a test you want to run. (you also can do just pytest now in the pandas directory, instead of doing pytest pandas) |
Sorry, can you clarify what a smoke test would mean in our test suite? |
Ah sorry. Not sure if it's too involved but a test in like
Then something that runs |
I think markers are still working, but just raising the unknown marker warning. I'll probably add a test to check that pyproject.toml can be found instead. |
Curious, why are the wheels only tested on windows? Also might be worth to error on warnings from pytest when running the tests? |
Linux/macOS is tested by cibuildwheel directly here. Windows is done in a separate step, since we test in an empty Docker container without MSVC installed to ensure that all DLLs are packaged in with the wheels.
I'll look into enabling erroring on warnings. |
Co-authored-by: Matthew Roeschke <[email protected]>
Looks like |
Looks pretty good. Appears these tests need to filter out potential RuntimeWarnings
|
Awesome! Thanks @lithomas1 |
This reverts commit 8023225.
pd.test
does not respect passing pandas specific markers #50302 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.