Skip to content

ENH: Include column for ea comparison in asserters #50323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 17, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

The previous exception message did not include the column which made debugging harder than necessary.

@phofl phofl added Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Dec 17, 2022
@gfyoung
Copy link
Member

gfyoung commented Dec 18, 2022

LGTM, not sure what's going on with GH Actions

@mroeschke mroeschke added this to the 2.0 milestone Dec 19, 2022
@mroeschke mroeschke merged commit 07b363e into pandas-dev:main Dec 19, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the testing branch December 19, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants