-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: add date_format to read_csv / Date parsing mistake. read_csv #50320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: add date_format to read_csv / Date parsing mistake. read_csv #50320
Conversation
f083cbd
to
27264cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. Needs a whatsnew note?
I don't think so, I don't have any example of where this makes a difference to users Basically, PDEP4 was supposed to fix #2586, but didn't because of an exception which was being swallowed by this try-except block Given that PDEP4 hasn't had an effect on users yet, I'd consider this just be part of that change and not have a separate whatsnew |
Thanks @MarcoGorelli |
With the removal of the dateutil code path, the docstring of
Although I suppose it was already outdated, because dateutil.parser was already a fallback after |
#50319 will happen to close #2586
This PR will make sure that bugs like #2586 don't appear again
Closes #2586