DOC: Add to the io documentation of on_bad_lines to alert users of silently skipped lines.
#50311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping @mroeschke |
mroeschke
reviewed
Dec 19, 2022
3 tasks
datapythonista
approved these changes
Jan 3, 2023
mroeschke
approved these changes
Jan 3, 2023
|
Thanks @kostyafarber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the documentation of
on_bad_linesfor reading CSV files. Specifically, when using user-defined callables foron_bad_linesany bad line that isn't a 'line with too many fields' is silently skipped. The user should be aware of this behaviour.The issue has been left open for further discussion of what is considered a 'bad line' and whether any code change should be made to accomodate the new definition of a bad line.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.