CLN: clean IntervalArray._simple_new #50305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/interval.py
Outdated
| closed: IntervalClosedType | None = None, | ||
| copy: bool = False, | ||
| dtype: Dtype | None = None, | ||
| dtype: IntervalDtype, | ||
| verify_integrity: bool = True, |
There was a problem hiding this comment.
ideally we'd get verify_integrity out of _simple_new
There was a problem hiding this comment.
I've made an implementation for this, see latest commit.
|
The arm failure looks unrelated. |
added 6 commits
December 26, 2022 20:01
topper-123
force-pushed
the
clean_IntervalArray._simple_new
branch
from
a8799f9 to
746bf29
Compare
|
I've updated the PR. |
| @@ -102,6 +105,7 @@ | |||
|
|
|||
|
|
|||
| IntervalArrayT = TypeVar("IntervalArrayT", bound="IntervalArray") | |||
| IntervalSideT = Union[TimeArrayLike, np.ndarray] | |||
There was a problem hiding this comment.
nice. an option if you want to be more specific can specify npt.NDArray[numeric_dtypes]. OK to call this out of scope
There was a problem hiding this comment.
I can do it in a follow-up? I think I'd prefer an iterative approach, i.e. closing the book on this method cleaning PR and picking up the typing issue as a new PR.
jbrockmendel
approved these changes
Dec 28, 2022
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of code in
IntervalArray._simple_new. I suggest moving all the code there that checks that the input data is correct into its own method (_ensure_simple_new_inputs), so we have a better split between building the ÌntervalArray` and checking that its inputs are correct.This PR changes no functionality.