CLN: Unify string storage fixture usage #50290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
reviewed
Dec 16, 2022
| @@ -76,7 +76,7 @@ def test_dont_register_by_default(self): | |||
| call = [sys.executable, "-c", code] | |||
| assert subprocess.check_call(call) == 0 | |||
|
|
|||
| @td.skip_if_no("matplotlib", min_version="3.1.3") | |||
| @td.skip_if_no("matplotlib") | |||
There was a problem hiding this comment.
There is a td.skip_if_no_mpl decorator. seems logical to use that?
There was a problem hiding this comment.
I think we can get rid of them altogether, lets see if ci is green
| @@ -111,7 +111,7 @@ def test_matplotlib_formatters(self): | |||
| assert Timestamp not in units.registry | |||
| assert Timestamp in units.registry | |||
|
|
|||
| @td.skip_if_no("matplotlib", min_version="3.1.3") | |||
| @td.skip_if_no("matplotlib") | |||
There was a problem hiding this comment.
Same question about td.skip_if_no_mpl .
topper-123
added
the
Testing
topper-123
approved these changes
Dec 17, 2022
|
Thanks @phofl. |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Dec 17, 2022
* CLN: Unify string storage fixture usage * Remove skips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.