Skip to content

BUG: Index[offset_objects] + Period #50282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2022
Merged

BUG: Index[offset_objects] + Period #50282

merged 1 commit into from
Dec 19, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 15, 2022 •
edited by mroeschke
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke
mroeschke reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #50162 in which case this is only an issue on main?

@mroeschke mroeschke added Numeric Operations Arithmetic, Comparison, and Logical operations Frequency DateOffsets Period Period data type labels Dec 17, 2022
@jbrockmendel
Copy link
Member Author

this is only an issue on main?

No, the incorrect raising also occurs on 1.5.0

@mroeschke mroeschke added this to the 2.0 milestone Dec 19, 2022
@mroeschke
Copy link
Member

So does the not necessarily close #50162?

@jbrockmendel
Copy link
Member Author

So does the not necessarily close #50162?

No

@mroeschke mroeschke merged commit 5237be5 into pandas-dev:main Dec 19, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-50162 branch December 19, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Frequency DateOffsets Numeric Operations Arithmetic, Comparison, and Logical operations Period Period data type
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke