Skip to content

CI: continue-on-error: true for scorecard action #50262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

mroeschke
Copy link
Member

This job on main is currently failing with a 500 error

 2022/12/14 18:00:45 error processing signature: http response 500, status: 500 Internal Server Error, error: {"code":500,"message":"something went wrong and we are looking into it."}

I am doubtful this is entirely actionable on our side (or if it ever will be), and it masks if there are actual failures on main so just letting this job "pass" even if there are these issues

@mroeschke mroeschke added the CI Continuous Integration label Dec 14, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mroeschke

this doesn't run on the PR, so might as well merge

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 14, 2022
@MarcoGorelli MarcoGorelli merged commit bf5ee72 into pandas-dev:main Dec 14, 2022
@mroeschke mroeschke deleted the ci/scorecard/continue branch December 14, 2022 20:46
@mroeschke
Copy link
Member Author

Darn that didn't work, maybe I have to manually skip the failing step

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error led me to believe you could do this for a entire job-id but I guess only if a strategy is used?

@lithomas1
Copy link
Member

We can just delete the job, honestly. I find it kind of annoying, to be honest, and I don't think it really is catching actual security issues.

If we already have CodeQL, I think we should be fine.

@MarcoGorelli
Copy link
Member

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants