Skip to content

Disallow cumprod for timedelta #50246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2022
Merged

Disallow cumprod for timedelta #50246

merged 3 commits into from
Dec 15, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 13, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @jbrockmendel as discussed on the other pr

@phofl phofl added the Timedelta Timedelta data type label Dec 13, 2022
@jbrockmendel
Copy link
Member

Does this need a whatsnew? otherwise LGTM thanks for following up!

@phofl
Copy link
Member Author

phofl commented Dec 15, 2022

Added whatsnew

@phofl phofl added this to the 2.0 milestone Dec 15, 2022
@phofl phofl merged commit 1488157 into pandas-dev:main Dec 15, 2022
@phofl phofl deleted the cumprod_timedelta branch December 15, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Timedelta Timedelta data type
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jbrockmendel