BUG: DataFrame reductions with object dtype and axis=1 #50224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct_reduction_axis_1_attempt_2 � Conflicts: � pandas/core/frame.py
…ct_reduction_axis_1_attempt_2 � Conflicts: � pandas/core/frame.py
…ct_reduction_axis_1_attempt_2
…ct_reduction_axis_1_attempt_2 � Conflicts: � doc/source/whatsnew/v2.0.0.rst
…ct_reduction_axis_1_attempt_2
…ct_reduction_axis_1_attempt_2
rhshadrach
added
Dtype Conversions
…m/rhshadrach/pandas into object_reduction_axis_1_attempt_2 � Conflicts: � pandas/core/nanops.py
…ct_reduction_axis_1_attempt_2
rhshadrach
commented
Dec 19, 2022
Comment on lines
727
to
745
| expected_dtype = { | ||
| "any": "bool", | ||
| "all": "bool", | ||
| "count": "int64", | ||
| "sum": "float", | ||
| "prod": "float", | ||
| "skew": "float", | ||
| "kurt": "float", | ||
| "sem": "float", | ||
| }.get(all_reductions, "object") | ||
| if using_array_manager and all_reductions in ( | ||
| "max", | ||
| "min", | ||
| "mean", | ||
| "std", | ||
| "var", | ||
| "median", | ||
| ): | ||
| expected_dtype = "float" |
There was a problem hiding this comment.
On main, there is no behavior change for array manager in this PR. For block manager, the reducers on L738-743 return float type on main but object type here.
…ct_reduction_axis_1_attempt_2
…m/rhshadrach/pandas into object_reduction_axis_1_attempt_2 � Conflicts: � pandas/tests/frame/test_reductions.py
…ct_reduction_axis_1_attempt_2 � Conflicts: � doc/source/whatsnew/v2.0.0.rst
…ct_reduction_axis_1_attempt_2
…m/rhshadrach/pandas into object_reduction_axis_1_attempt_2
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
3 tasks
|
Closing in favor of #51335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.In #49616 I attempted to only remove the errant cast to float, but this lead to the issue that, e.g. for axis=1 the sum of boolean columns becomes object. Unconditionally taking the block manager reduce path solves this problem, but then we run into the issue of taking a transpose of a frame with no columns (see the comments in the diff here). This PR resolves that issue, but is a bit of a hack (I can't seem to find any other resolution).
In the test here, there are some reductions (e.g. mean) that one may have expected float back instead - I've opened #49618 for this.